[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix incorrect `|| fail` pattern in tests
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] tests: fix incorrect `|| fail` pattern in tests |
|
Date: |
Mon, 2 Mar 2020 08:12:48 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 2020-03-01 17:30, Pádraig Brady wrote:
> On 01/03/2020 15:26, Bernhard Voelker wrote:
>> On 2020-02-29 22:07, Pádraig Brady wrote:
>>> * tests/ls/stat-free-symlinks.sh: s/|| fail/|| fail=1/.
>>> * tests/misc/tee.sh: Likewise.
>>> * tests/touch/relative.sh: Likewise.
>>> * cfg.mk (sc_prohibit_or_fail): A new syntax-check to avoid this.
>>
>> Nice catch, these test bugs are quite old (2012, 2012 and 2015).
>> How did you spot these?
>
> I introduced the same myself in another change,
> but noticed when double checking before commit,
> then grepping the pattern showed the others.
Nice, so that was really a little trap worth the syntax-check.
I hope there had not been any test error slipping through due to that.
Have a nice day,
Berny