coreutils and GCC -fanalyzer

[Paul Eggert]

The coreutils patch installed on May 10 to pacify GCC 10 -fanalyzer 
caused problems when I built coreutils with GCC 10.1.0. Some of the 
newly-introduced pragmas generated diagnostics, and the pragmas didn't 
seem to be needed in GCC 10.1.0 anyway. As 10.1.0 is the first public 
release of GCC 10 I doubt whether we need to support GCC internal 
versions (before GCC 10.1.0) that had problems with -fanalyze.

Also, the patch seems to have introduced a bug in tsort.c due to a typo. 
Less importantly, it introduced some new overhead in dd.c's non-lint 
code (to save some pointers in global variables) that isn't needed and 
might cause problems with other static checkers.

To try to fix all this I installed the attached patches.

At some point I hope this GCC 10 stuff settles down, as GCC 10.1.0 still 
has bugs in the -fanalyzer area (e.g., see GCC bugs 93644, 95044, 95072) 
and we don't want these bugs to adversely affect coreutils etc.

0001-maint-omit-unnecessary-pragmas-and-fix-tsort.c.patch
Description: Text Data

0002-dd-omit-unnecessary-vars-when-lint.patch
Description: Text Data