Re: [PATCH] tests: fix removed-directory test

[Pádraig Brady]

On 23/05/2020 17:46, Bernhard Voelker wrote:
> On 2020-05-23 18:08, Pádraig Brady wrote:
> > On 23/05/2020 02:45, Bernhard Voelker wrote:
> > > +# On NFS, 'ls' would run into the error "Stale file handle".
> > > +test -d . || skip_ "can't examine removed working directory on this platform"
>
> > It might be worth putting a require_local_dir_ at the top of the test also?
>
> Actually I was unsure whether to test for the actual error ("Stale file 
> handle"),
> using 'test -d .' as Paul did, and to generally rule out remote file systems.
> Maybe the latter is a too big hammer?  I mean, this test should verify a certain
> behavior on any file system type.

I think the general `test -d .` test is fine.
Any other cases would be unusual, and we'd only be skipping the test in those 
cases anyway.

cheers,
Pádraig.