Re: lib/dirfd.c: compiler warning: unused parameter

[Pádraig Brady]

On 07/05/2023 19:16, Bernhard Voelker wrote:
> On 5/5/23 12:13, Bruno Haible wrote:
> > 2023-05-05  Bruno Haible  <bruno@clisp.org>
> >
> >         dirfd: Fix bogus override (regression 2023-04-26).
> >         Reported by Bjarni Ingi Gislason <bjarniig@simnet.is> in
> >         <https://lists.gnu.org/archive/html/bug-gnulib/2023-05/msg00040.html>.
> >         * m4/dirfd.m4 (gl_FUNC_DIRFD): Fix mistake in last change.
>
> Gnulib commit 3f0950f65abb (2023-04-26) not only lead to build time
> issues, but also made e.g. coreutils' rm(1) fail:
>
>     $ mkdir d && (cd d && seq 400000 | xargs touch )
>
>     $ rm -rf d
>     rm: traversal failed: d: Operation not supported
>
> I can confirm that this gnulib commit d4d8abb39eb0 fixes the issue again.
>
> I noticed the issue because the following "very-expensive" tests failed
> (which succeeded with coreutils-9.3):
>
>     FAIL: tests/rm/ext3-perf
>     FAIL: tests/rm/many-dir-entries-vs-OOM

+1

As a reminder to me, we may have to adjust the year2038 build info
that was updated recently with:
https://github.com/coreutils/coreutils/commit/cc95246ee
But we can do that after the fact.

thanks!

Pádraig