Re: error: Support the compiler's control flow analysis better (was: copy-file: Silence gcc warnings)

[Pádraig Brady]

On 31/05/2023 18:46, Jim Meyering wrote:
> On Wed, May 31, 2023 at 9:12 AM Pádraig Brady <P@draigbrady.com> wrote:
> > -           'error \(.*%s[:"], .*(name|file)[^"]*\);$$' *.c; \
> > +           '${error_fns} \(.*%s[:"], .*(name|file)[^"]*\);$$' *.c; \
>
> Thanks!
> Was there a reason to prefer curly braces there, rather than the more
> conventional parentheses?
>
>             '$(error_fns) \(.*%s[:"], .*(name|file)[^"]*\);$$' *.c; \

I had a slight preference for the curly braces since it was used in a shell 
pipeline
and so it's immediately obvious it's a ${variable interpolation}
rather than being misread as a $(command substitution).

cheers,
Pádraig