coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug#1037275: dd: regression - posix expression syntax no longer supp


From: Pádraig Brady
Subject: Re: Bug#1037275: dd: regression - posix expression syntax no longer supported
Date: Sun, 11 Jun 2023 23:13:22 +0100
User-agent: Mozilla Thunderbird

On 11/06/2023 18:29, Jim Meyering wrote:
Thanks. The patch looks fine.
My only suggestion would be a stylistic one, to change the ">"
comparison to be the equivalent "<" one, i.e., change this:

+      && *suffix == 'B' && (suffix > str && suffix[-1] != 'B'))

to this (also dropping the unnecessary parentheses):

+      && *suffix == 'B' && str < suffix && suffix[-1] != 'B')

Why? Because of the increasing-to-right number-line argument, where
smaller things are visually on the left of larger ones.

Currently, in src/, the uses of space-delimited < and <= outnumber
uses of > and >= by four to one, 1678 to 428.

Pushed with that adjustment.

thanks
Pádraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]