[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bold by moving pixels problem
From: |
Kim F. Storm |
Subject: |
Re: Bold by moving pixels problem |
Date: |
19 Dec 2002 13:18:55 +0100 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
Miles Bader <address@hidden> writes:
> address@hidden (Kim F. Storm) writes:
> > I've looked at your patch, and it seems to be very low-level to give
> > the filter functions direct access to the actual lface vector elements.
>
> Well, it's a low-level thing... :-)
>
> > I'd suggest a different approach using the internal-lisp-face attribute
> > names that are already defined in xfaces.c such as :family, :height, etc.
>
> I agree, code filled with `(aref .. 3)' is not good. Going all the
> way to a plist seems a bit gratuitous though.
IMHO, the only argument for the current implementation vs. a plist would be
performance.
>
> What about just providing accessor/setter macros for `lface' vectors,
> e.g., (lface-weight LFACE) and (set-lface-weight LFACE VAL)?
IMO, That's just adding stuff to remedy the wrong approach; the plist approach
doesn't need adding _any_ new stuff at the lisp level.
>
> After all the `lface' representation _is_ exposed to lisp already, so
> such macros might help other code as well.
Excuse my ignorance, but where is that exposed already?
>
> [I'm not sure about the term `lface' though -- it's used fairly
> pervasively in the C code, but of course that's from the perspective of
> the C code...]
It seems to be called (internal-)lisp-face in stuff like internal-make-lisp-face
(try apropos on "internal lisp face"). lisp-face-vector may be a good name?
--
Kim F. Storm <address@hidden> http://www.cua.dk
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/17
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/17
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/17
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/18
- Re: Bold by moving pixels problem, Kim F. Storm, 2002/12/18
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/19
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/19
- Re: Bold by moving pixels problem,
Kim F. Storm <=
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/19
- Re: Bold by moving pixels problem, Miles Bader, 2002/12/19
- Re: Bold by moving pixels problem, Kim F. Storm, 2002/12/19
- Re: Bold by moving pixels problem, Robert J. Chassell, 2002/12/18
- signal handling bogosities, Miles Bader, 2002/12/19
- Re: signal handling bogosities, Richard Stallman, 2002/12/20
- Re: signal handling bogosities, Alex Schroeder, 2002/12/20
- Re: signal handling bogosities, Eli Zaretskii, 2002/12/20
- Re: signal handling bogosities, Miles Bader, 2002/12/20
- Re: signal handling bogosities, Richard Stallman, 2002/12/21