[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: address@hidden: Re: mode-line redisplay bug]
From: |
YAMAMOTO Mitsuharu |
Subject: |
Re: address@hidden: Re: mode-line redisplay bug] |
Date: |
Tue, 11 Oct 2005 10:21:33 +0900 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/22.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) |
>>>>> On Mon, 10 Oct 2005 20:40:18 +0100, Jason Rumney <address@hidden> said:
> "Jan D." <address@hidden> writes:
>> AFAIK co-ordinates on W32 behave the same as on X, so your patch
>> should be OK. It is easy to confirm anyway.
> OK, I've installed the patch, but as YAMAMOTO Mitsuharu pointed out,
> it may not deal with the left fringe width - which might be an
> explanation for the gx calculation being off by one, and possibly
> also the explanation for why this patch does work as I expected.
A simple debug code below shows the incorrectness of the calculated
rectangle :-). And if it is corrected, the problem I said in
http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-06/msg00148.html
will appear.
>>>>> On Tue, 07 Jun 2005 18:45:48 +0900, YAMAMOTO Mitsuharu <address@hidden>
>>>>> said:
> 2.1 Sometimes a tooltip is not shown. I hope the first
> fragment of the patch below fix this.
> 2.2 The value of last_mouse_glyph may become invalid. For
> example, after clicking the image on the splash screen,
> dragging the area where the image was displayed does not
> issue mouse-movement events. I think last_mouse_glyph
> should be cleared in some appropriate timing, but I'm not
> sure when it is.
YAMAMOTO Mitsuharu
address@hidden
Index: src/xterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xterm.c,v
retrieving revision 1.879
diff -c -r1.879 xterm.c
*** src/xterm.c 10 Oct 2005 22:54:19 -0000 1.879
--- src/xterm.c 11 Oct 2005 01:10:58 -0000
***************
*** 3675,3680 ****
--- 3677,3688 ----
rect->height = r->height;
rect->x = WINDOW_TO_FRAME_PIXEL_X (w, gx);
rect->y = WINDOW_TO_FRAME_PIXEL_Y (w, r->y);
+
+ XDrawRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
+ f->output_data.x->normal_gc,
+ rect->x - 1, rect->y - 1,
+ rect->width + 2, rect->height + 2);
+
return 1;
}
break;
- Re: address@hidden: Re: mode-line redisplay bug], Jason Rumney, 2005/10/08
- Re: address@hidden: Re: mode-line redisplay bug], mituharu, 2005/10/08
- Re: address@hidden: Re: mode-line redisplay bug], Jan D., 2005/10/09
- Re: address@hidden: Re: mode-line redisplay bug], Jason Rumney, 2005/10/10
- Re: address@hidden: Re: mode-line redisplay bug], Jason Rumney, 2005/10/11
- Re: address@hidden: Re: mode-line redisplay bug], Kim F. Storm, 2005/10/11
- Re: address@hidden: Re: mode-line redisplay bug], YAMAMOTO Mitsuharu, 2005/10/11
- Re: address@hidden: Re: mode-line redisplay bug], Kim F. Storm, 2005/10/12
- Re: address@hidden: Re: mode-line redisplay bug], YAMAMOTO Mitsuharu, 2005/10/12
- Re: address@hidden: Re: mode-line redisplay bug], Kim F. Storm, 2005/10/12
- Re: address@hidden: Re: mode-line redisplay bug], YAMAMOTO Mitsuharu, 2005/10/12