[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GCC warning in minibuf.c
From: |
Andreas Schwab |
Subject: |
Re: GCC warning in minibuf.c |
Date: |
Thu, 20 Oct 2005 15:07:47 +0200 |
User-agent: |
Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
> Here, the 2nd argument `function' is declared to accept a single
> Lisp_Object argument. However, minibuf.c calls
> internal_with_output_to_temp_buffer as follows:
>
> internal_with_output_to_temp_buffer ("*Completions*",
> Fdisplay_completion_list,
> Fsort (completions, Qstring_lessp));
>
> and Fdisplay_completion_list is declared to accept 2 Lisp_Object
> arguments.
Then Fdisplay_completion_list is definitely the wrong function to pass to
internal_with_output_to_temp_buffer.
> I think this is a bogus warning,
I don't agree. Fdisplay_completion_list will be called with only a single
parameter and will receive garbage in the second one. A sure way to make
Emacs crash.
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."