[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 23.0.50; face-problems with multy-tty
From: |
Johan Bockgård |
Subject: |
Re: 23.0.50; face-problems with multy-tty |
Date: |
Tue, 18 Sep 2007 15:55:36 +0200 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) |
Richard Stallman <address@hidden> writes:
> The old code boiled down to calling `set-face-attribute' with a null
> FRAME argument. This sets a new frame default that is the same for all
> frames (via face-new-frame-defaults). That is not what we want.
>
> The new code calls set-face-attribute locally for each frame. It does
> not set a default in face-new-frame-defaults. This DTRT unless a default
> exists in face-new-frame-defaults (or an X resource exists for the
> face).
>
> You are basically right. It's just that I think the change you made
> really needs to be inside face-spec-set.
Ok, I agree.
> That way, face-spec-set will DTRT _also_.
This still isn't quite the right thing:
(set-face-attribute 'font-lock-string-face nil :foreground "yellow")
(custom-set-faces
'(font-lock-string-face
((((class color) (background light)) (:foreground "red"))
(((class color) (background dark)) (:foreground "blue")))))
;; `C-x 5 2' uses a yellow font-lock-string-face.
I think custom-set-faces (and face-spec-set?) should clear the new-frame
default.
--
Johan Bockgård
- Re: 23.0.50; face-problems with multy-tty, (continued)
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/08
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/07
- Re: 23.0.50; face-problems with multy-tty, Johan Bockgård, 2007/09/07
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/08
- Re: 23.0.50; face-problems with multy-tty, Tassilo Horn, 2007/09/08
- Re: 23.0.50; face-problems with multy-tty, Johan Bockgård, 2007/09/13
- RE: 23.0.50; face-problems with multy-tty, Drew Adams, 2007/09/13
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/14
- overriding a face [was: 23.0.50; face-problems with multy-tty], Drew Adams, 2007/09/30
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/16
- Re: 23.0.50; face-problems with multy-tty,
Johan Bockgård <=
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/23
- Re: 23.0.50; face-problems with multy-tty, Johan Bockgård, 2007/09/23
- Re: 23.0.50; face-problems with multy-tty, Eli Zaretskii, 2007/09/24
- Re: 23.0.50; face-problems with multy-tty, Johan Bockgård, 2007/09/24
- Re: 23.0.50; face-problems with multy-tty, Eli Zaretskii, 2007/09/24
- Re: 23.0.50; face-problems with multy-tty, Johan Bockgård, 2007/09/26
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/25
- Re: 23.0.50; face-problems with multy-tty, Johan Bockgård, 2007/09/26
- Re: 23.0.50; face-problems with multy-tty, Richard Stallman, 2007/09/27
- Re: 23.0.50; face-problems with multy-tty, Johan Bockgård, 2007/09/27