[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: shouldn't substitute-command-keys remove duplicates?
From: |
Juri Linkov |
Subject: |
Re: shouldn't substitute-command-keys remove duplicates? |
Date: |
Sat, 22 Mar 2008 03:29:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) |
> Yes, duplicates should be removed, just as in menus.
>
>> As an example, filecache.el does this (via ;;;###autoload):
>> (define-key minibuffer-local-completion-map
>> [C-tab] 'file-cache-minibuffer-complete)
>> (define-key minibuffer-local-map
>> [C-tab] 'file-cache-minibuffer-complete)
>> (define-key minibuffer-local-must-match-map
>> [C-tab] 'file-cache-minibuffer-complete)
>
> In the mean time, could someone fix filecache.el so as not to put those
> redundant bindings? Thanks,
I see this was already fixed on 2007-11-21 on the 22 branch and on the
trunk. The only small inessential fix is necessary is the following one
(since `map' is locally bound to `minibuffer-local-map'). I suggest Drew to
use the latest Emacs source code before reporting bugs to emacs-pretest-bug.
Index: lisp/bindings.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/bindings.el,v
retrieving revision 1.199
diff -c -r1.199 bindings.el
*** lisp/bindings.el 21 Mar 2008 23:59:04 -0000 1.199
--- lisp/bindings.el 22 Mar 2008 01:29:31 -0000
***************
*** 776,782 ****
;; indent-for-tab-command). The alignment that indent-relative tries to
;; do doesn't make much sense here since the prompt messes it up.
(define-key map "\t" 'self-insert-command)
! (define-key minibuffer-local-map [C-tab] 'file-cache-minibuffer-complete))
(define-key global-map "\C-u" 'universal-argument)
(let ((i ?0))
--- 776,782 ----
;; indent-for-tab-command). The alignment that indent-relative tries to
;; do doesn't make much sense here since the prompt messes it up.
(define-key map "\t" 'self-insert-command)
! (define-key map [C-tab] 'file-cache-minibuffer-complete))
(define-key global-map "\C-u" 'universal-argument)
(let ((i ?0))
--
Juri Linkov
http://www.jurta.org/emacs/