[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
dbusbind.c patch, fixes possible segfault
From: |
David Hansen |
Subject: |
dbusbind.c patch, fixes possible segfault |
Date: |
Sun, 13 Apr 2008 16:28:46 +0200 |
User-agent: |
Gnus/5.110009 (No Gnus v0.9) Emacs/23.0.60 (gnu/linux) |
This one is similar to the previous dbusbind.c patch. No need to copy
the string and if dbus_bus_get_unique_name () returns NULL strcpy will
segfault.
David
2008-04-13 David Hansen <address@hidden>
* dbusbind.c (dbus-get-unique-name): Remove extra copying of name
string.
*** dbusbind.c.~1.24.~ 2008-04-05 23:46:55.000000000 +0200
--- dbusbind.c 2008-04-13 15:19:27.000000000 +0200
***************
*** 701,707 ****
Lisp_Object bus;
{
DBusConnection *connection;
! char name[DBUS_MAXIMUM_NAME_LENGTH];
/* Check parameters. */
CHECK_SYMBOL (bus);
--- 701,707 ----
Lisp_Object bus;
{
DBusConnection *connection;
! const char *name;
/* Check parameters. */
CHECK_SYMBOL (bus);
***************
*** 710,716 ****
connection = xd_initialize (bus);
/* Request the name. */
! strcpy (name, dbus_bus_get_unique_name (connection));
if (name == NULL)
xsignal1 (Qdbus_error, build_string ("No unique name available"));
--- 710,716 ----
connection = xd_initialize (bus);
/* Request the name. */
! name = dbus_bus_get_unique_name (connection);
if (name == NULL)
xsignal1 (Qdbus_error, build_string ("No unique name available"));
- dbusbind.c patch, fixes possible segfault,
David Hansen <=
- Re: dbusbind.c patch, fixes possible segfault, Michael Albinus, 2008/04/13
- Re: dbusbind.c patch, fixes possible segfault, David Hansen, 2008/04/13
- Re: dbusbind.c patch, fixes possible segfault, David Hansen, 2008/04/14
- Re: dbusbind.c patch, fixes possible segfault, Eli Zaretskii, 2008/04/14
- Re: dbusbind.c patch, fixes possible segfault, Michael Albinus, 2008/04/14
- Re: dbusbind.c patch, fixes possible segfault, David Hansen, 2008/04/14
- Re: dbusbind.c patch, fixes possible segfault, Glenn Morris, 2008/04/14
- Re: dbusbind.c patch, fixes possible segfault, Stefan Monnier, 2008/04/14
- Re: dbusbind.c patch, fixes possible segfault, Glenn Morris, 2008/04/15
- Re: dbusbind.c patch, fixes possible segfault, Stefan Monnier, 2008/04/14