emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Recent trunk build crashes a lot under Win32


From: Stefan Monnier
Subject: Re: Recent trunk build crashes a lot under Win32
Date: Thu, 17 Apr 2008 22:26:26 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> I think you mean this part.

>   1392                  if (!STRING_MULTIBYTE (tem))
>   1393                    {
>   1394                      /* FIXME: DECODE_FILE may GC, which may move 
> SDATA(name),
>   1395                         after which `nm' won't point to the right 
> place any more.  */
>   1396                      int offset = nm - SDATA (name);
>   1397                      hdir = DECODE_FILE (tem);
>   1398                      newdir = SDATA (hdir);
>   1399                      nm = SDATA (name) + offset;
>   1400                    }

> But `nm' does not always point to the string data of `name' on some
> platforms.

>   1160          nm = SDATA (name);
>   1161        
>   1162        #ifdef DOS_NT
>   1163          /* We will force directory separators to be either all \ or 
> /, so make
>   1164             a local copy to modify, even if there ends up being no 
> change. */
>   1165          nm = strcpy (alloca (strlen (nm) + 1), nm);

Good point.  I hope I've fixed it now,


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]