[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs/lisp ChangeLog vc-bzr.el
From: |
Óscar Fuentes |
Subject: |
Re: emacs/lisp ChangeLog vc-bzr.el |
Date: |
Mon, 07 Dec 2009 00:12:08 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
> CVSROOT: /sources/emacs
> Module name: emacs
> Changes by: Chong Yidong <cyd> 09/12/06 20:22:19
>
> Modified files:
> lisp : ChangeLog vc-bzr.el
>
[snip]
> Index: vc-bzr.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/vc-bzr.el,v
> retrieving revision 1.89
> retrieving revision 1.90
> diff -u -b -r1.89 -r1.90
> --- vc-bzr.el 3 Dec 2009 08:53:06 -0000 1.89
> +++ vc-bzr.el 6 Dec 2009 20:22:19 -0000 1.90
> @@ -572,8 +572,12 @@
> (inhibit-read-only t))
> (setq string (substring string (match-end 0)))
> (unless tag
> - (setq tag (propertize rev 'help-echo (concat "Author: " author
> - ", date: " date)
> + (setq tag
> + (propertize
> + (concat rev " " (substring author 0 7))
> + 'help-echo (format "Revision: %d, author: %s, date: %s"
> + (string-to-number rev)
> + author date)
> 'mouse-face 'highlight))
> (puthash key tag table))
> (goto-char (process-mark proc))
That change fails on (substring author 0 7) when `author' contains less
than 7 characters:
error in process filter: concat: Args out of range: "oscar", 0, 7
error in process filter: Args out of range: "oscar", 0, 7
I tried with a kludge:
(substring (concat author " ") 0 7)
and that fixed the problem.
I tried this variation too:
(substring author 0 (min 7 (length author)))
but the result is not so pretty, as the "author" column has no fixed
width anymore.
--
Óscar
- Re: emacs/lisp ChangeLog vc-bzr.el,
Óscar Fuentes <=