RE: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Changedefault-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[Drew Adams]

> From: Drew Adams Sent: Sunday, June 27, 2010 7:07 AM
> >
> > Change default-frame-alist and menu/tool-bar-mode 
> > interaction (Bug#2249).  Don't add entries for `menu-bar-lines'
> > and `tool-bar-lines' to `default-frame-alist' and
> > `initial-frame-alist' at startup.  Instead, use X resources
> > to update the `menu-bar-mode' and `tool-bar-mode' variables
> > at startup, and use them as defaults during frame creation.
> 
> I haven't followed this and cannot check the new effect.  But 
> I hope this does not mean that a user's customizations of, say, 
> `default-frame-alist' will no longer be respected wrt
> `menu-bar-lines' and `tool-bar-lines'.
> 
> When you say "use X resources", do you mean that Emacs now 
> sets X resources or only that users can use X resources to set
> these parameters? (You say "use X resources" the same way you
> say "don't add entries", so it's unclear what the
> subject of the sentence is: Emacs code or the user.)
> 
> ---
> 
> FWIW: Over the past few major releases there has been 
> considerable fiddling with initial menu-bar and tool-bar
> settings and how they're established.  I hope this
> will settle down and reach a fixed point. ;-)  As an example, 
> I have code that fits the frame to a buffer, and it has to
> calculate the frame height differently for different Emacs
> versions, because of the different treatment of these
> parameters.

See my mail from today, subject "tool bars - broken again".

I suspect that the change Yidong describes is in fact what broke things.

[The breakage is not what I feared it might be (size of tool-bar lines or
non-respect of `default-frames-alist').  Instead, it seems that turning off
`tool-bar-mode' does not set `tool-bar-lines' to 0 for `default-frame-alist'.]