Re: Patch for PHP5 support for etags

[Olivier Sirven]

On 2012-02-24 11:36:06, Olivier Sirven wrote:
> On 2011-04-26 14:36:35, Lennart Borgman wrote:
>> On Tue, Apr 26, 2011 at 2:25 PM, Francesco Potortì <address@hidden> wrote:
>>>
>>> Yes, I applied the patch.  I tested it and got strange results.  So I
>>> need a php5 source file together with the expected results, so that I
>>> can check it with more confidence.  Can you provide that, or point me to
>>> someone else who can?
>>
>> Maybe some of those that have contributed to php-mode.el can?
>
> I'm no php-mode.el contributor but I do code in PHP5 every single
> working day using emacs for a long time now. 
> I was previously forcing language detection to java in order to have
> something usable even though not perfect.
>
> I've just found out about this PHP5 patch for etags and just gave it a
> try. As far as I can see it works just fine, all my declarations are
> there and I don't see any strange results.
>
> If you need any help getting this into the main code base I'd be glad to
> help. But first I need to understand what you mean by "strange results"
> so I can check whether or not I do have the same issue

I see nobody has interest into PHP5 for etags...so sad!

So maybe I'm the only one but what can/should I do to get this patch
merged?

-- 
Oliv