[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at.
From: |
Lars Magne Ingebrigtsen |
Subject: |
Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at. |
Date: |
Mon, 12 Aug 2013 17:32:12 +0200 |
User-agent: |
Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) |
Juanma Barranquero <address@hidden> writes:
> +2013-08-12 Juanma Barranquero <address@hidden>
> +
> + * xml.el (xml-parse-tag-1): Use looking-at (this reverts change in
> + revno:113793, which breaks the test suite).
> + https://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00263.html
[...]
> - (while (not (looking-at-p end))
> + (while (not (looking-at end))
Wouldn't it be better to fix the bogus test instead of changing
apparently perfectly good code (for the (slightly) worse)?
That's the danger of test suites. >"?
--
(domestic pets only, the antidote for overdose, milk.)
No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at.,
Lars Magne Ingebrigtsen <=
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Juanma Barranquero, 2013/08/12
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Lars Magne Ingebrigtsen, 2013/08/12
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Juanma Barranquero, 2013/08/12
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Glenn Morris, 2013/08/12
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Lars Magne Ingebrigtsen, 2013/08/12
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Stefan Monnier, 2013/08/12
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Juanma Barranquero, 2013/08/12
- Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at., Lars Magne Ingebrigtsen, 2013/08/13