[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r113896: Declare external variables.
From: |
Xue Fuqiao |
Subject: |
Re: [Emacs-diffs] trunk r113896: Declare external variables. |
Date: |
Sat, 17 Aug 2013 06:38:46 +0800 |
On Fri, Aug 16, 2013 at 3:34 PM, Michael Albinus <address@hidden> wrote:
> Stefan Monnier <address@hidden> writes:
>
>>> +(eval-when-compile
>>> + (defvar directory-sep-char)
>>> + (defvar dired-move-to-filename-regexp))
>>
>> You don't want to "eval" those defvars, since evaluating such a defvar is
>> mostly a no-op. So don't put them inside eval-when-compile.
> I've written it this way for didactic purposes: it reminds me what it is
> good for (byte-compiler!).
Like Stefan said, it burdens the byte-compiler. You can add some
comments before it.
--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/