[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: trunk r113947: * image.c: Fix animation cache signature memory leak.
From: |
Lars Magne Ingebrigtsen |
Subject: |
Re: trunk r113947: * image.c: Fix animation cache signature memory leak. |
Date: |
Mon, 19 Aug 2013 18:19:46 +0200 |
User-agent: |
Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) |
Paul Eggert <address@hidden> writes:
>> you didn't test it,
>> because it segfaulted the first time it was called.
>
> I did test it, but evidently not with enough test cases.
> Sorry about the bug.
But it would crash with any (animated) image, because it never allocated
a cache. If I read the code correctly. :-)
> To avoid such problems in the future, should we funnel future
> image.c changes through you?
No no.
> Here's a tiny style issue that should be fixed at some point: the
> version you inserted has "strcmp(" in a couple of places where it
> should be "strcmp (".
No, please go ahead and fix.
--
(domestic pets only, the antidote for overdose, milk.)
No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Lars Magne Ingebrigtsen, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Paul Eggert, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak.,
Lars Magne Ingebrigtsen <=
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Paul Eggert, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Lars Magne Ingebrigtsen, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Paul Eggert, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Lars Magne Ingebrigtsen, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Paul Eggert, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Lars Magne Ingebrigtsen, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Paul Eggert, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Lars Magne Ingebrigtsen, 2013/08/19
- Re: trunk r113947: * image.c: Fix animation cache signature memory leak., Lars Magne Ingebrigtsen, 2013/08/19