[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Lexical byte-compilation warnings cleanup
From: |
Stefan Monnier |
Subject: |
Re: Lexical byte-compilation warnings cleanup |
Date: |
Thu, 22 Aug 2013 16:41:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> IMO, this does not explain what happens actually. I would rather prefer
> such variant:
> Warning: Lexically bound argument shadows dynamic variable %s
Better, indeed, thank you,
Stefan
=== modified file 'lisp/emacs-lisp/cconv.el'
--- lisp/emacs-lisp/cconv.el 2013-06-14 02:31:28 +0000
+++ lisp/emacs-lisp/cconv.el 2013-08-22 20:41:05 +0000
@@ -552,7 +552,8 @@
(cond
((byte-compile-not-lexical-var-p arg)
(byte-compile-log-warning
- (format "Argument %S is not a lexical variable" arg)))
+ (format "Lexical argument shadows the dynamic variable %S"
+ arg)))
((eq ?& (aref (symbol-name arg) 0)) nil) ;Ignore &rest, &optional, ...
(t (let ((varstruct (list arg nil nil nil nil)))
(cl-pushnew arg byte-compile-lexical-variables)
- RE: Lexical byte-compilation warnings cleanup, (continued)
- RE: Lexical byte-compilation warnings cleanup, Drew Adams, 2013/08/20
- Re: Lexical byte-compilation warnings cleanup, Stefan Monnier, 2013/08/20
- RE: Lexical byte-compilation warnings cleanup, Drew Adams, 2013/08/20
- RE: Lexical byte-compilation warnings cleanup, Stephen J. Turnbull, 2013/08/20
- RE: Lexical byte-compilation warnings cleanup, Drew Adams, 2013/08/20
- Re: Lexical byte-compilation warnings cleanup, Stefan Monnier, 2013/08/21
- Re: Lexical byte-compilation warnings cleanup, Dmitri Paduchikh, 2013/08/21
- Re: Lexical byte-compilation warnings cleanup, Stefan Monnier, 2013/08/21
Re: Lexical byte-compilation warnings cleanup, Barry OReilly, 2013/08/21