[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view.
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view. |
Date: |
Mon, 06 Jan 2014 10:05:21 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> + Fix defun navigation in vc log view.
[...]
> (if (< arg 0)
> + (log-view-end-of-defun (- arg))
This looks very fishy. beginning-of-defun-function should never move to
the end of a defun, even when called with a negative argument.
So, if this is really correct, it needs a comment explaining why this is
the right thing to do. And if you could add some regression tests for your
commit it would be even better.
Stefan
- Re: [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view.,
Stefan Monnier <=