[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] About the :distant-foreground face attribute
From: |
Jan Djärv |
Subject: |
Re: [PATCH] About the :distant-foreground face attribute |
Date: |
Tue, 14 Jan 2014 23:05:48 +0100 |
14 jan 2014 kl. 21:06 skrev Daniel Colascione <address@hidden>:
> On 01/14/2014 12:01 PM, Jan Djärv wrote:
>>
>> No. If Emacs generates a color, Emacs desides what looks good. If
>> the system defines a color, the system (or the user if customized)
>> desides what looks good. I don't think it matters what I think about
>> colors generated by your patch, I might even think they look better
>> than many system defined colors. But as a principle I think the
>> desision is not Emacs to make *by default*. Users may of course
>> apply customizations to Emacs and change it.
>
> In 24.4, Emacs has already been changed to override the system selection
> foreground color with various font-lock faces.
Which font lock faces are you talking about? No system I know of defines
system colors for things like comment face, function face etc.
> Why is it okay to do that when there's no contrast problem, but suddenly,
> when there's a contrast problem, we can say that the principle of following
> system colors is important?
The principle of following system foreground is only important if system
background is used.
This is currently for NS/Gtk+ only. For Lucid/Motif/No toolkit, we don't use
system colors at all, because they are not known and can not be known,
because the API to get them is not available.
> You're applying this principle very selectively.
System background + contrast problem => system foreground.
How is that selectively, it is a clear rule.
> If you're going to override the system color selection, you need to do it
> well and consistently, and automatic contrast adjustment is the best way to
> go about solving the inevitable contrast problems that arise when you combine
> colors you control with colors you don't.
Again, I don't know what faces except region faces a system defines colors
for, so when you say Emacs overrides system colors for font-lock faces, I
don't know what faces you are talking about.
If there are system colors that are applicable as font-lock face colors, then
that is news to me.
Jan D.
- Re: [PATCH] Re: About the :distant-foreground face attribute, (continued)
- Re: [PATCH] Re: About the :distant-foreground face attribute, Daniel Colascione, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Jan D., 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Stefan Monnier, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Jan Djärv, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Daniel Colascione, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, John Yates, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Stefan Monnier, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Daniel Colascione, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Jan Djärv, 2014/01/14
- Re: [PATCH] Re: About the :distant-foreground face attribute, Daniel Colascione, 2014/01/14
- Re: [PATCH] About the :distant-foreground face attribute,
Jan Djärv <=
- Re: [PATCH] About the :distant-foreground face attribute, Daniel Colascione, 2014/01/14
- Re: [PATCH] About the :distant-foreground face attribute, Jan Djärv, 2014/01/15
- Re: [PATCH] About the :distant-foreground face attribute, Daniel Colascione, 2014/01/15
- Re: [PATCH] About the :distant-foreground face attribute, Jan D., 2014/01/15
- Re: [PATCH] About the :distant-foreground face attribute, Stefan Monnier, 2014/01/15
- Re: [PATCH] Re: About the :distant-foreground face attribute, Daniel Colascione, 2014/01/14
- Re: [PATCH] About the :distant-foreground face attribute, Jan Djärv, 2014/01/14
- RE: [PATCH] About the :distant-foreground face attribute, Drew Adams, 2014/01/14
- Re: [PATCH] About the :distant-foreground face attribute, Eli Zaretskii, 2014/01/14
- RE: [PATCH] About the :distant-foreground face attribute, Drew Adams, 2014/01/14