[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patches with independent changes
From: |
Eli Zaretskii |
Subject: |
Re: Patches with independent changes |
Date: |
Sat, 25 Jan 2014 19:25:19 +0200 |
> Date: Sat, 25 Jan 2014 09:01:21 -0800
> From: Paul Eggert <address@hidden>
> Cc: address@hidden
>
> --- update-game-score.c-old 2014-01-25 08:31:13.065305429 -0800
> +++ update-game-score.c 2014-01-25 08:31:54.337506871 -0800
> @@ -443,8 +443,13 @@
> fd = mkostemp (tempfile, 0);
> if (fd < 0)
> return -1;
> +#ifdef WINDOWSNT
> + if (chmod (tempfile, 0644) != 0)
> + return -1;
> +#else
> if (fchmod (fd, 0644) != 0)
> return -1;
> +#endif
> f = fdopen (fd, "w");
> if (! f)
> return -1;
This code is plain wrong: you cannot chmod a file that is open, if you
try, the chmod call will fail.
Again, I just restored the old code, but only for WINDOWSNT. The
reason for that was that I wanted a safe change, since we are in a
feature freeze. In any case, the fact that the problem could have
been solved in more than one way doesn't mean there are multiple
changes involved.
- Re: Changes in update-game-score.c, (continued)
- Patches with independent changes, Paul Eggert, 2014/01/24
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/24
- Re: Patches with independent changes, Paul Eggert, 2014/01/24
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/25
- Re: Patches with independent changes, Paul Eggert, 2014/01/25
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/25
- Re: Patches with independent changes,
Eli Zaretskii <=
- Re: Patches with independent changes, Paul Eggert, 2014/01/25
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/25
- Re: Patches with independent changes, Paul Eggert, 2014/01/26