[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert
From: |
Noam Postavsky |
Subject: |
Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert |
Date: |
Mon, 30 Jan 2017 21:53:11 -0500 |
On Sun, Jan 29, 2017 at 4:09 PM, Clément Pit-Claudel
<address@hidden> wrote:
>> Um, should this be
>>
>> (funcall debugger 'error `(cl-assertion-failed ,form ,string ,@sargs))
>>
>> or
>>
>> (funcall debugger 'error `(cl-assertion-failed (,form ,string ,@sargs)))
>>
>> I'm getting confused with all the levels of nesting and funcall/apply.
>
>
> I think the second one. `debugger' gets two arguments, 'error and a list of
> arguments to `signal'. That list should have two entries:
> `cl-assertion-failed' and `(,form ,string ,@sargs).
>
Pushed to emacs-25 [1: 72ef710].
1: 2017-01-30 21:45:02 -0500 72ef710f6e1c8e334fd50da9480a8cb151e823a2
Fix call to debugger on assertion failure