Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit)

[Phillip Lord]

Dmitry Gutov <address@hidden> writes:

> On 7/8/17 2:53 PM, Eli Zaretskii wrote:
>
>> It's actually more than that: patches submitted to Emacs need to
>> conform to our coding and various other standards: include
>> properly-formatted commit log messages, documentation, and (where
>> appropriate) tests, etc.  Patch review could require cleanup changes
>> etc.
>
> That doesn't negate the advantages of integrated solutions like
> GitLab, though. Emacs is not the only project with standards.
>
> We often enforce those via code review, and GitLab helps with that.

And the process is much easier in most projects. Push to feature branch,
get comments, using line-level in diff commenting. Then fix, squash,
force push. Finally, single click merge, PR closes.

Phil