|
From: | Alex |
Subject: | Re: master 69fb12a: (loadhist-unload-element): Move ERT and cl-generic methods |
Date: | Tue, 25 Jul 2017 00:46:56 -0600 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
address@hidden (Stefan Monnier) writes: > branch: master > commit 69fb12a66b3d6b9bfb55d8bcd58bec2a8e7ca55b > Author: Stefan Monnier <address@hidden> > Commit: Stefan Monnier <address@hidden> > > (loadhist-unload-element): Move ERT and cl-generic methods > > * lisp/loadhist.el (loadhist-unload-element): Don't define cl-generic > and ert methods here. > (loadhist-unload-element) <(head define-type)>: Remove unused var `slots'. > > * lisp/emacs-lisp/cl-generic.el (loadhist-unload-element): Define > unload method for cl-defmethod. > (cl-generic-ensure-function): Remove redundant `defalias'. > > * lisp/emacs-lisp/ert.el (ert-set-test): Move the current-load-list > setting here... > (ert-deftest): ...from here. > (loadhist-unload-element): Define unload method for ert-deftest. This commit breaks defgeneric for me. Specifically, this: (eieio--defgeneric-init-form 'test "Hello") returns nil after this commit, leading to an assertion error in eieio--defalias. I found this out because I couldn't load Helm (the problem file is helm-source.el).
[Prev in Thread] | Current Thread | [Next in Thread] |