The issue with with-temp-buffer (or with-current-buffer)

[OGAWA Hirofumi]

Hi,

The following is the reproduce code of issue,

(let ((buf (get-buffer-create "test-case")))
  (display-buffer buf)
  (with-current-buffer buf
    (erase-buffer)
    (insert "1\n")
    ;; start suspect
    (with-temp-buffer
      (save-window-excursion
        (set-window-buffer nil (current-buffer))))
    ;; end suspect
    (insert "2\n")))

and expected result is

    ---- test-case ----
    2
    1
    -------------------

But actual result is

    ---- test-case ----
    1
    2
    -------------------

[The actual issue that I'm hitted was using `shr-insert-document'
like following. And above is simplied version to reproduce the issue.

  (with-current-buffer buf
    (erase-buffer)
    (insert ...)
    (shr-insert-document '(html nil (body nil ...)))
    (insert ...)))
]

After some debugging, I noticed `with-current-buffer' that is
used in `with-temp-buffer' doesn't restore `point'.

And if I replaced `with-current-buffer' with
save-excursion+set-buffer, the issue is fixed.

I.e. from
        (with-temp-buffer
to
        (save-excursion
          (set-buffer ,temp-buffer)

Well so, this behavior (doesn't restore point) of
`with-temp-buffer' (or `with-current-buffer') is intented or bug?

And to fix this issue, we should change which one of
with-temp-buffer, with-current-buffer, shr-insert-document, or
user of shr-insert-document?

Thanks.
-- 
OGAWA Hirofumi <address@hidden>