[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] master cfa7c4e: Add missing file gited-ci.el
From: |
Stefan Monnier |
Subject: |
Re: [elpa] master cfa7c4e: Add missing file gited-ci.el |
Date: |
Sat, 19 May 2018 14:57:12 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> +;;; gited-ci.el --- Obtain CI status of the trunk branch -*-
> lexical-binding:t -*-
> +;;
This is missing the copyright and licence blurbs.
> +(defcustom gited-show-trunk-ci-status nil
> + "Show CI status for the last commit in the trunk branch.
> +An alist of conses ((TOPLEVEL_DIR_1 . CI-URI_1) (TOPLEVEL_DIR_2 . CI-URI_2)
> ... ).
I usually prefer to say
... a list of elements of the form (TOPLEVEL-DIR . CI-URI) ...
So you don't need to talk about the "_I" thingy.
But other than this mostly irrelevant nitpick, I have a more serious
comment to make: why not rely on dir-locals variable for that?
Stefan
- Re: [elpa] master cfa7c4e: Add missing file gited-ci.el,
Stefan Monnier <=