[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merging bignum to master
From: |
Paul Eggert |
Subject: |
Re: Merging bignum to master |
Date: |
Mon, 13 Aug 2018 15:58:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Pip Cet wrote:
I notice that there are a few places where you use XFIXNUMPTR
directly, rather than make_mint_ptr. Is that intentional? I think now
would be a good time to fix it and make XFIXNUMPTR internal to lisp.h.
It's intentional since those few places don't need the full power of
make_mint_ptr (often the pointers are already aligned) and there might be
trouble if storage allocation fails if the pointer is not aligned. Perhaps
you're right and this is overkill; it is confusing at any rate. In the meantime
I installed the attached first patch to fix a glitch I saw in this area while
looking at the current XFIXNUMPTR uses.
Also, the doc comments for most_negative_fixnum and
most_positive_fixnum in data.c still need updating.
Thanks, done in the second attached patch.
0001-Fix-check-for-unsafe-watch-descriptor.patch
Description: Text Data
0002-Update-doc-strings-for-fixnum-constants.patch
Description: Text Data
- Re: Merging bignum to master, (continued)
- Re: Merging bignum to master, Paul Eggert, 2018/08/16
- Re: Merging bignum to master, Stefan Monnier, 2018/08/16
- Re: Merging bignum to master, Ulrich Mueller, 2018/08/12
- Re: Merging bignum to master, Eli Zaretskii, 2018/08/12
- Re: Merging bignum to master, Ulrich Mueller, 2018/08/12
- Re: Merging bignum to master, Paul Eggert, 2018/08/12
Re: Merging bignum to master, John Wiegley, 2018/08/12
Re: Merging bignum to master, Pip Cet, 2018/08/12
- Re: Merging bignum to master, Tom Tromey, 2018/08/12
- Re: Merging bignum to master,
Paul Eggert <=
- Re: Merging bignum to master, Noam Postavsky, 2018/08/13
- Re: Merging bignum to master, Pip Cet, 2018/08/14
- Re: Merging bignum to master, Paul Eggert, 2018/08/14
- Re: Merging bignum to master, Pip Cet, 2018/08/15
- Re: Merging bignum to master, Paul Eggert, 2018/08/15
- Re: Merging bignum to master, Andy Moreton, 2018/08/15
- Re: Merging bignum to master, Stefan Monnier, 2018/08/16
Some vars now limited to fixnum size. (Was: Merging bignum to master), Karl Fogel, 2018/08/20
Re: Some vars now limited to fixnum size. (Was: Merging bignum to master), Paul Eggert, 2018/08/20
Re: Some vars now limited to fixnum size. (Was: Merging bignum to master), Eli Zaretskii, 2018/08/20