|
From: | Paul Eggert |
Subject: | Re: [Emacs-diffs] master 1d2df2f: Improve bignum comparison |
Date: | Wed, 22 Aug 2018 08:06:34 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Eli Zaretskii wrote:
This commit does this: * src/data.c (isnan): Remove, as we can assume C99. We indeed assume a C99 compliant compiler, but not necessarily a C99 compliant library. Does the above assumption still valid if the library is not C99-compliant?
Other parts of Emacs have been assuming isnan since July, so this should be safe here.
In practice isnan support is universal nowadays in the non-Microsoft world, and even MSVC has it, as I understand it. If there are problems (when compiling for MS-Windows 95, say?) we can fix them by doing something like adding "#define isnan _isnan" in src/w32.h. It's better to isolate portability hacks to platform-specific code, when the problem is platform-specific.
[Prev in Thread] | Current Thread | [Next in Thread] |