|
From: | Paul Eggert |
Subject: | Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches |
Date: | Wed, 22 Aug 2018 14:53:24 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Pip Cet wrote:
Well, it's harder to implement this than I thought at first, since we want to change `eq' and `most-positive-fixnum' but not EQ and MOST_POSITIVE_FIXNUM.
If we go this route, we should rename EQ (say, to just E) and write a new EQ function in C that acts like Emacs eq, and similarly rename MOST_POSITIVE_FIXNUM. It'd be pretty confusing otherwise. Not sure it's worth the effort.
No objections to that patch, but `eq' is correct in that code: string length is limited by STRING_BYTES_BOUND,
Ah, good catch. I got confused because one argument of the 'eq' call can be a bignum; trouble can't occur unless both are bignums. I changed that eql back to eq.
[Prev in Thread] | Current Thread | [Next in Thread] |