[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Replace trivial pcase occurrences in the Emacs sources
From: |
Michael Heerdegen |
Subject: |
Re: Replace trivial pcase occurrences in the Emacs sources |
Date: |
Tue, 06 Nov 2018 02:04:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
> I obviously didn't proofread all of the changes, but what I did looked
> good.
Thanks. I'll wait some more days to see whether there are more
comments.
BTW, I think I'll revert the apparent fix in
diff --git a/lisp/calendar/time-date.el b/lisp/calendar/time-date.el
index c3898e0257..bb54ad46e3 100644
--- a/lisp/calendar/time-date.el
+++ b/lisp/calendar/time-date.el
@@ -109,7 +109,7 @@ with-decoded-time-value
,(append `(setq ,pico 0)
(when type `(,type 2)))))
(type
- `(setq type 2))))
+ `(setq ,type 2))))
,(append `(setq ,micro 0)
(when pico `(,pico 0))
(when type `(,type 1)))))
The affected macro 'with-decoded-time-value' has been obsolete since
25.1, so I would prefer to just leave it as is. It's not used anywhere
in Emacs.
Michael.
- Re: Replace trivial pcase occurrences in the Emacs sources, (continued)
- Re: Replace trivial pcase occurrences in the Emacs sources, Stefan Monnier, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Noam Postavsky, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/11/01
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/11/04
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/11/04
- Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/11/05
- Re: Replace trivial pcase occurrences in the Emacs sources,
Michael Heerdegen <=
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/11/25
- Re: Replace trivial pcase occurrences in the Emacs sources, Nicolas Goaziou, 2018/11/25
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/11/25
- Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/11/25
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/11/26
- Re: Replace trivial pcase occurrences in the Emacs sources, Nicolas Goaziou, 2018/11/26
- Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/11/27
Re: Replace trivial pcase occurrences in the Emacs sources, Andy Moreton, 2018/11/01
Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/11/03