|
From: | Dmitry Gutov |
Subject: | Re: [Emacs-diffs] master b0e318d 2/2: Score flex-style completions according to match tightness |
Date: | Sun, 17 Mar 2019 19:51:36 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 16.03.2019 15:02, João Távora wrote:
I didn't read the test fully, but it seems you (or I? did I write it?) are asserting that there can only be a specific set of properties in the completion candidate. This is wrong: there can be more unrelated to your package's use of those candidate's properties, completion-score being one of them.
You did, but that's neither here not there. A fix PR would be welcome, but I'll get around to it otherwise myself, no problem.
Though I do think `company.el` should start making use of `completion-score` somehow.
Sure. But either completion-all-completions starts doing that automatically, or we'll need the new variable to appear in the core first.
[Prev in Thread] | Current Thread | [Next in Thread] |