emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposed changes to gnus-dup.el


From: Lars Ingebrigtsen
Subject: Re: Proposed changes to gnus-dup.el
Date: Mon, 25 Mar 2019 18:42:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

"Basil L. Contovounesios" <address@hidden> writes:

> +      (unless (or (gnus-data-pseudo-p datum)
> +                  (<= (gnus-data-number datum) 0)

I'm against using `unless' on complex logic -- many people get confused
when reading it in my experience.

The rest looks OK.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]