[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Unit tests and lexical-binding for delim-col.el
|
From: |
Noam Postavsky |
|
Subject: |
Re: [PATCH] Unit tests and lexical-binding for delim-col.el |
|
Date: |
Tue, 7 May 2019 19:03:41 -0400 |
On Tue, 7 May 2019 at 18:45, Basil L. Contovounesios <address@hidden> wrote:
> You said you were disinclined to adapt delim-col.el itself, but how
> about bundling the following minor cleanups as well?
> -(defmacro delimit-columns-str (str)
> - `(if (stringp ,str) ,str ""))
> +(defsubst delimit-columns-str (str)
> + (if (stringp str) str ""))
I think you may as well go with defun here, delimit-columns-str isn't
being used in some performance-critical spot, as far as I can tell.
- [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/07
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/07
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el,
Noam Postavsky <=
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/09
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Monnier, 2019/05/09
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/11
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/20
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/30