emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c


From: Eli Zaretskii
Subject: Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c
Date: Mon, 26 Aug 2019 22:33:41 +0300

> From: Óscar Fuentes <address@hidden>
> Date: Mon, 26 Aug 2019 21:15:17 +0200
> 
> > The initialization in this case was added because GCC flagged a
> > potential use-before-define.  After that, there's no more bug for
> > Valgrind to find, so I see no reason to leave UNINIT around.
> 
> Let's suppose that the warning was correct and the hacker was wrong when
> judged it bogus.

The warning was correct, and I didn't decide it was bogus.  I added
the initialization because the warning was NOT bogus.  Please see the
code and the comment.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]