[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "If you're still seeing problems, please reopen." [Was: bug#25148:]

From: João Távora
Subject: Re: "If you're still seeing problems, please reopen." [Was: bug#25148:]
Date: Wed, 20 Nov 2019 19:29:58 +0000

On Wed, Nov 20, 2019 at 5:44 PM Eli Zaretskii <address@hidden> wrote:
> > From: João Távora <address@hidden>
> > Date: Wed, 20 Nov 2019 16:53:09 +0000
> > Cc: Lars Ingebrigtsen <address@hidden>, Óscar Fuentes <address@hidden>,
> >       emacs-devel <address@hidden>, Richard Stallman <address@hidden>, 
> > Dmitry Gutov <address@hidden>
> >
> > On Wed, Nov 20, 2019 at 4:27 PM Eli Zaretskii <address@hidden> wrote:
> >
> > > > Of course, if somebody wants to hit the "merge pull request" button
> > > > in Gitlab, they can do that, but for most smaller pull requests,
> > > > Gitlab would just email the patch (presumably) and we can apply it
> > > > locally on our machines before pushing to the repo, just like now.
> > >
> > > What you describe is not the PR workflow that people are used to.
> >
> > I don't think it's very far off, though.  Here's my usual workflow with
> > GitHub, in the hope that it helps the discussion:
> AFAIU, you described the wokflow of a developer, not of a
> contributor.  I was rather talking about the latter, and mainly before
> their PR is accepted and merged.

Well, yeah, but from the contributor's side the process is very
similar. Apart from not being able actually merge the PR
to master, he changes the PR's branch in the very same
ways as I (the developer) described in my previous email.
(Again, without ever touching the Web UI, if he/she so wishes).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]