emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for fit-window-to-buffer


From: martin rudalics
Subject: Re: Patch for fit-window-to-buffer
Date: Thu, 5 Mar 2020 10:12:57 +0100

> I think the (point-max) is unnecessary here actually. According to the
> docstring for window-text-pixel-size, nil should work here, no?

It should work.

>> Finally, the (frame-pixel-width) argument looks fishy too - it should
>> probably be (frame-pixel-width (window-frame window)).  Can you verify
>> that as well?
>
> Yes, I made that change and the previous one in the patch attached. Both
> work with my test case.

Applied to Emacs-27 (without asking for Eli's permission because the
bugs were all to obvious).

Thanks, martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]