[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: policy regarding DEFUNs in subr-x.el

From: Tassilo Horn
Subject: Re: policy regarding DEFUNs in subr-x.el
Date: Sun, 22 Mar 2020 21:38:08 +0100
User-agent: Cyrus-JMAP/3.1.7-1021-g152deaf-fmstable-20200319v1

Didn't we decide that replace-region-contents is to be moved to replace.el? 
Sorry, I didn't follow that past discussion/patch closely but from my pov that 
would make sense, and given that this function is new in emacs 27, now is the 
best time doing so.


Am So, 22. Mär 2020, um 18:12, schrieb Eli Zaretskii:
> > From: Štěpán Němec <address@hidden>
> > Date: Sun, 22 Mar 2020 16:46:36 +0100
> > 
> > Now, it does seem sensible for the function to be a normal, not inline,
> > function, but what about the commentary and all the other defsubsts,
> > including the other string utilities?
> > 
> > If the no-defun policy should be changed, or if I was mistaken in
> > believing there was one to begin with, shouldn't the commentary
> > recommending compile-time usage be removed, and at least some of the
> > other defsubsts turned into defuns, too?
> I don't see that the commentary says the code in this file must be
> inline.  If something in the wording implies that, let's change the
> wording so that it doesn't.
> From my POV, there's no reason to require that everything in that file
> is inlined, and that single "outlier" is the evidence.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]