[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-27 d66331a: Don't build the Gnulib 'utimens' module on MinGW

From: Robert Pluim
Subject: Re: emacs-27 d66331a: Don't build the Gnulib 'utimens' module on MinGW
Date: Tue, 24 Mar 2020 21:31:47 +0100

>>>>> On Tue, 24 Mar 2020 20:56:28 +0200, Eli Zaretskii <address@hidden> said:

    >> From: Robert Pluim <address@hidden>
    >> Cc: address@hidden
    >> Date: Tue, 24 Mar 2020 18:07:13 +0100
    >> In that case I should go the other direction. How about the following
    >> to remove the 1-char readahead for sockets (which then allows us to
    >> enable datagram sockets on MSWindows).

    Eli> I have no idea whether and how the result will differ from what we do
    Eli> today.  The sheer amount of "remarks" in the MSDN documentation scares
    Eli> me.  E.g., what happens if the remote end closes the socket,
    Eli> gracefully or otherwise?

We still end up calling read on the socket, just later, so those
error conditions should still be handled. Iʼll note that the gnulib
implementation of select does essentially the same thing (it uses
MsgWaitForMultipleObjects rather than WaitForSingleObject, but I
assume they do much the same thing under the covers).

    Eli> IOW, I'd love someone who _really_ knows about Windows socket
    Eli> programming to review this and compare with what we do now.  I'm not
    Eli> that person, sorry.

Nor am I. Iʼd suggest adding it as a disabled option, but then nobody
would ever use it....


reply via email to

[Prev in Thread] Current Thread [Next in Thread]