[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus
From: |
Robert Pluim |
Subject: |
Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus |
Date: |
Tue, 31 Mar 2020 12:16:18 +0200 |
>>>>> On Tue, 31 Mar 2020 11:53:36 +0200, Andreas Schwab <address@hidden> said:
Andreas> On Mär 31 2020, Robert Pluim wrote:
>> @@ -245,11 +252,15 @@ 'open-protocol-stream
>> "26.1")
>>
>> (defun network-stream-open-plain (name buffer host service parameters)
>> - (let ((start (with-current-buffer buffer (point)))
>> - (stream (make-network-process :name name :buffer buffer
>> - :host (puny-encode-domain host)
>> - :service service
>> - :nowait (plist-get parameters
:nowait))))
>> + (let* ((start (with-current-buffer buffer (point)))
>> + (coding-p (plist-member parameters :coding))
>> + (coding-val (plist-get parameters :coding))
>> + (args (append (list :name name :buffer buffer
>> + :host (puny-encode-domain host)
>> + :service service
>> + :nowait (plist-get parameters :nowait))
>> + (when coding-p (list :coding coding-val))))
>> + (stream (apply #'make-network-process args)))
Andreas> You don't need to use apply. Since :coding nil is the same as the
Andreas> default, you can just pass `:coding (plist-get parameters :coding)'
Andreas> unconditionally.
My reading of set_network_socket_coding_system is that having a plist
in make-network-process with :coding nil overrides a non-nil
coding-system-for-{read-write}, which I donʼt think we want.
Robert
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus, Robert Pluim, 2020/03/31
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus, Andreas Schwab, 2020/03/31
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus,
Robert Pluim <=
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus, Andreas Schwab, 2020/03/31
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus, Robert Pluim, 2020/03/31
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus, Robert Pluim, 2020/03/31
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus, Eli Zaretskii, 2020/03/31
- Re: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus, Robert Pluim, 2020/03/31