[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer ba
From: |
Philipp Stephani |
Subject: |
Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis. |
Date: |
Sat, 11 Apr 2020 18:57:20 +0200 |
Am Mi., 8. Apr. 2020 um 16:58 Uhr schrieb Stefan Monnier
<address@hidden>:
>
> > How strongly do people feel about having a minor mode for this? If not
> > too strongly, I'd go ahead with my original proposal, which is simpler
> > implementation-wise.
>
> I don't think you can do much simpler than the patch I sent and it lets
> users inhibit the mode in those mode where they don't want it with:
>
> (add-hook 'foo-mode-hook
> (lambda () (setq-local auto-save-visited-mode nil)))
>
> and it's "compatible" with a future addition of an actual minor mode.
> As mentioned, having such "redundant checks" is common practice for
> minor modes.
>
Didn't we already discuss this above? It's against our own
recommendations for minor modes, so we shouldn't put it into the Emacs
codebase itself.
Unless I hear strong objections, I'll push my original approach in a few days.
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., (continued)
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Philipp Stephani, 2020/04/05
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Stefan Monnier, 2020/04/05
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Philipp Stephani, 2020/04/05
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Stefan Monnier, 2020/04/05
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Philipp Stephani, 2020/04/05
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Philipp Stephani, 2020/04/08
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Eli Zaretskii, 2020/04/08
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Philipp Stephani, 2020/04/08
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Eli Zaretskii, 2020/04/08
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Stefan Monnier, 2020/04/08
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis.,
Philipp Stephani <=
- Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Stefan Monnier, 2020/04/11
Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis., Philipp Stephani, 2020/04/05