[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix misnamed variable breaking GNUstep Emacs.app build
From: |
Alan Third |
Subject: |
Re: [PATCH] Fix misnamed variable breaking GNUstep Emacs.app build |
Date: |
Sat, 18 Apr 2020 20:49:47 +0100 |
On Sat, Apr 18, 2020 at 12:19:11PM -0700, Ahmed Khanzada wrote:
> On Sat, 18 Apr 2020 05:30:31 -0700,
> The result of the git format patch -1 is attached to this email.
>
> Sorry for the inline patch, that is just how OpenBSD prefers it. Should
> all patches be attachments going forward, or just the end stages before
> ommit? Inline is sometimes easier to review.
For discussion, if it’s not too big, inline is probably as good as
anything. In this particular case I was just hoping you’d write the
commit message. I suppose I wasn’t clear. If you look in the
CONTRIBUTE file there’s information about the preferred format. It’s
worth checking it out if you’re planning on contributing again.
I’ll sort this patch and push it to master.
Thanks!
--
Alan Third