diff --git a/lisp/tooltip.el b/lisp/tooltip.el index ffc3d499e3..8ca56f2100 100644 --- a/lisp/tooltip.el +++ b/lisp/tooltip.el @@ -67,6 +67,10 @@ tooltip-mode ;;; Customizable settings +;; keep true while testing, will be default nil +(defcustom tooltip-enable-sticky-tips t + "Seconds to wait before displaying a tooltip the first time." + :type 'boolean) (defcustom tooltip-delay 0.7 "Seconds to wait before displaying a tooltip the first time." @@ -175,6 +179,9 @@ tooltip-hide-time (defvar gud-tooltip-mode) ;; Prevent warning. +(defvar sticky-tooltip-timer nil + "Time during which sticky tooltip is not hidden.") + ;;; Event accessors (defun tooltip-event-buffer (event) @@ -210,6 +217,10 @@ tooltip-timeout (run-hook-with-args-until-success 'tooltip-functions tooltip-last-mouse-motion-event)) +(defun tooltip-start-sticky-timer () + (setq sticky-tooltip-timer + (run-with-timer tooltip-hide-delay nil 'tooltip-hide) + sticky-is-up t)) ;;; Displaying tips @@ -237,6 +248,8 @@ tooltip-show Optional second arg USE-ECHO-AREA non-nil means to show tooltip in echo area." + ;; while testing keep gtk tips off + (setq x-gtk-use-system-tooltips nil) (if use-echo-area (tooltip-show-help-non-mode text) (condition-case error @@ -248,12 +261,47 @@ tooltip-show (setf (alist-get 'border-color params) fg)) (when (stringp bg) (setf (alist-get 'background-color params) bg)) - (x-show-tip (propertize text 'face 'tooltip) - (selected-frame) + + (unless x-gtk-use-system-tooltips + (with-current-buffer (get-buffer-create " *tip*") + (let ((inhibit-read-only t)) + (erase-buffer) + (remove-overlays) + (insert (propertize text 'face 'tooltip)) + + (when tooltip-enable-sticky-tips + (goto-char (point-min)) + (let ((cur-line 0) + (lng-line 0)) + (while (not (eobp)) + (setq cur-line (- (line-end-position) (line-beginning-position))) + (when (> cur-line lng-line) + (setq lng-line cur-line)) + (forward-line)) + (newline) + (insert (make-string (- lng-line 6) ?─)) + (widget-insert " Sticky ") + (widget-create 'checkbox + :notify + (lambda (s &rest ignore) + (if (widget-value s) + (message "START WIDGET") + (message "EXIT WIDGET")))) + (use-local-map widget-keymap) + (widget-setup)))))) + + ;; text properties are now handled, in buffer, and + ;; 'text' argument is only needed for gtk-tooltips + ;; (not used if we are here) + (x-show-tip text + (selected-frame) params tooltip-hide-delay tooltip-x-offset - tooltip-y-offset)) + tooltip-y-offset) + + (when tooltip-enable-sticky-tips + (tooltip-start-sticky-timer))) (error (message "Error while displaying tooltip: %s" error) (sit-for 1) @@ -368,7 +416,8 @@ tooltip-show-help (cond ((null msg) ;; Cancel display. This also cancels a delayed tip, if ;; there is one. - (tooltip-hide)) + (unless sticky-tooltip-timer + (tooltip-hide))) ((equal-including-properties previous-help msg) ;; Same help as before (but possibly the mouse has moved). ;; Keep what we have. @@ -376,6 +425,8 @@ tooltip-show-help (t ;; A different help. Remove a previous tooltip, and ;; display a new one, with some delay. + (when sticky-tooltip-timer + (cancel-timer sticky-tooltip-timer)) (tooltip-hide) (tooltip-start-delayed-tip)))) ;; On text-only displays, try `tooltip-show-help-non-mode'. diff --git a/src/xfns.c b/src/xfns.c index 46e4bd73a6..afb26b6b94 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -6909,7 +6909,6 @@ DEFUN ("x-show-tip", Fx_show_tip, Sx_show_tip, 1, 6, 0, dy = make_fixnum (-10); else CHECK_FIXNUM (dy); - #ifdef USE_GTK if (x_gtk_use_system_tooltips) { @@ -6930,6 +6929,7 @@ DEFUN ("x-show-tip", Fx_show_tip, Sx_show_tip, 1, 6, 0, unblock_input (); if (ok) goto start_timer; } + #endif /* USE_GTK */ if (FRAMEP (tip_frame) && FRAME_LIVE_P (XFRAME (tip_frame))) @@ -7081,20 +7081,20 @@ DEFUN ("x-show-tip", Fx_show_tip, Sx_show_tip, 1, 6, 0, buffer. */ count_1 = SPECPDL_INDEX (); old_buffer = current_buffer; - set_buffer_internal_1 (XBUFFER (w->contents)); - bset_truncate_lines (current_buffer, Qnil); - specbind (Qinhibit_read_only, Qt); - specbind (Qinhibit_modification_hooks, Qt); - specbind (Qinhibit_point_motion_hooks, Qt); - Ferase_buffer (); - Finsert (1, &string); - clear_glyph_matrix (w->desired_matrix); - clear_glyph_matrix (w->current_matrix); - SET_TEXT_POS (pos, BEGV, BEGV_BYTE); - try_window (window, pos, TRY_WINDOW_IGNORE_FONTS_CHANGE); - /* Calculate size of tooltip window. */ + // set_buffer_internal_1 (XBUFFER (w->contents)); + // bset_truncate_lines (current_buffer, Qnil); + // specbind (Qinhibit_read_only, Qt); + // specbind (Qinhibit_modification_hooks, Qt); + // specbind (Qinhibit_point_motion_hooks, Qt); + // Ferase_buffer (); + // Finsert (1, &string); + // clear_glyph_matrix (w->desired_matrix); + // clear_glyph_matrix (w->current_matrix); + // SET_TEXT_POS (pos, BEGV, BEGV_BYTE); + // try_window (window, pos, TRY_WINDOW_IGNORE_FONTS_CHANGE); + // /* Calculate size of tooltip window. */ size = Fwindow_text_pixel_size (window, Qnil, Qnil, Qnil, - make_fixnum (w->pixel_height), Qnil); + make_fixnum (w->pixel_height), Qnil); /* Add the frame's internal border to calculated size. */ width = XFIXNUM (Fcar (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_f); height = XFIXNUM (Fcdr (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_f);