[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Pushing the mark from a primitive like goto-char

From: Gabriel do Nascimento Ribeiro
Subject: Re: Pushing the mark from a primitive like goto-char
Date: Wed, 06 Jan 2021 16:26:45 -0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

"Daniel Martín via \"Emacs development discussions."
<emacs-devel@gnu.org> writes:

> martin rudalics <rudalics@gmx.at> writes:
>>>> I'd then try to make it behave like 'M-g g' in this regard.
>>> Some interactive versions of low-level primitives have the suffix
>>> `...-command' in their names, so a command like 'M-g g' and bound to
>>> 'M-g c' could be named 'goto-char-command'.
>> I was more concerned about not pushing the mark when the region is
>> already active so one can use M-g c to extend the region.  BTW, is there
>> a reason why 'goto-map' is so terribly unpopulated?
> This sounds like a good idea:
> - Create a 'goto-char-command' command in ELisp.
> - Move the interactive spec that is in 'goto-char' to this new command
>   and make it push the mark smartly (e.g. be careful when a region is
>   active).  Then call 'goto-char'.
> - Rebind 'M-g c' to 'goto-char-command'.
> - Announce the new command.
> What do you think? Could it break something? Thanks.

Thank you!
I guess we missed the :group definition, here is a patch:

diff --git a/lisp/mb-depth.el b/lisp/mb-depth.el
index ea2ea174b5..22315cd93f 100644
--- a/lisp/mb-depth.el
+++ b/lisp/mb-depth.el
@@ -37,7 +37,8 @@ minibuffer-depth-indicator-function

 (defface minibuffer-depth-indicator '((t :inherit highlight))
   "Face to use for minibuffer depth indicator."
-  :version "28.1")
+  :version "28.1"
+  :group 'basic-faces)

 ;; An overlay covering the prompt.  This is a buffer-local variable in
 ;; each affected minibuffer.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]