[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Omitting :group [was: master 7936c8a: * lisp/mb-depth.el (minibuf

From: Eli Zaretskii
Subject: Re: Omitting :group [was: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.]
Date: Thu, 07 Jan 2021 17:54:38 +0200

> Date: Thu, 7 Jan 2021 15:41:28 +0000 (UTC)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: Juri Linkov <juri@linkov.net>, emacs-devel@gnu.org
> > This change causes a byte-compilation warning:
> >   In toplevel form:
> >   mb-depth.el:38:1: Warning: defface for
> >   `minibuffer-depth-indicator' fails to specify
> >   containing group
> IMHO, we should adopt and promote a guideline
> that it's a good, not a bad, idea to always
> include an explicit `:group'.

Aren't you confusing :group in defcustom with :group in defface?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]