[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ai_flags in calls to getaddrinfo, broader call for reproducibility c

From: Robert Pluim
Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check
Date: Tue, 12 Jan 2021 10:44:57 +0100

Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Mon 11 Jan 2021, Robert Pluim wrote:
>> Eli Zaretskii <eliz@gnu.org> writes:
>> The results can be trusted. However, the assumption of the tests is
>> that DNS lookups on AAAA records will work, and return results for
>> google.com, which is not the case for you. If you prefer we can change
>> the tests to check for "no error" rather than 'returns a result' (is
>> there an ERT 'should-not-error' clause)?
> CAn the tests please be changed to assume that IPv6 is not always
> avvailable and AAAA lookup may fail ? There are many people using
> networks without IPv6 available. These tests usually fail or hang on my
> systems.

The IPv6 tests are only run when Emacs is compiled with IPv6
support. The question "is IPv6 available" is harder to answer, but we
can take a stab at it.

None of the tests should hang. If you can pinpoint ones that do,
please let us know.

> It would be better if the tests did not rely on external connectivity,
> and did not need to contact google.com gratuitously.
>     AndyM

They donʼt contact google.com, they perform DNS lookups on
google.com. The connectivity tests we have connect to localhost.

External connectivity is one of the big features of Emacs, it should
be tested by the test suite.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]