[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Compatibility patches for EDE / EIEIO
From: |
Stefan Monnier |
Subject: |
Re: Compatibility patches for EDE / EIEIO |
Date: |
Mon, 18 Jan 2021 12:52:16 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> The short answer to your questions is that I'm not very familiar with how
> the typing system works with the latest eieio changes.
I suspect we're the two most knowledgeable about it, so if you have
a doubt about one part I hope I can help.
> I'm fine with the proposed use of (list-of ...) as it seems much
> simpler and more obvious.
OK, I've changed the code to use that.
> I would expect you would want to make the same change in ede/base.el around
> line 172, which is the code I used as a template to make :rules work.
> Maybe something like the below patch?
Looks good to me.
So, I pushed the patch below,
Stefan
diff --git a/lisp/cedet/ede/base.el b/lisp/cedet/ede/base.el
index 7799746e0c..810d6ef3bd 100644
--- a/lisp/cedet/ede/base.el
+++ b/lisp/cedet/ede/base.el
@@ -160,16 +160,13 @@ ede-project-placeholder
;; Projects can also affect how EDE works, by changing what appears in
;; the EDE menu, or how some keys are bound.
;;
-(unless (fboundp 'ede-target-list-p)
- (cl-deftype ede-target-list () '(list-of ede-target)))
-
(defclass ede-project (ede-project-placeholder)
((subproj :initform nil
:type list
:documentation "Sub projects controlled by this project.
For Automake based projects, each directory is treated as a project.")
(targets :initarg :targets
- :type ede-target-list
+ :type (list-of ede-target)
:custom (repeat (object :objectcreatefcn ede-new-target-custom))
:label "Local Targets"
:group (targets)
diff --git a/lisp/cedet/ede/proj.el b/lisp/cedet/ede/proj.el
index 59628ebf4c..4af8b4104f 100644
--- a/lisp/cedet/ede/proj.el
+++ b/lisp/cedet/ede/proj.el
@@ -184,7 +184,7 @@ ede-proj-target-makefile
commands where the variable would usually appear.")
(rules :initarg :rules
:initform nil
- :type list
+ :type (list-of ede-makefile-rule)
:custom (repeat (object :objecttype ede-makefile-rule))
:label "Additional Rules"
:group (make)