[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [feature/native-comp] breakage on build

From: Andrea Corallo
Subject: Re: [feature/native-comp] breakage on build
Date: Sat, 30 Jan 2021 20:17:58 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: phillip.lord@russet.org.uk,  emacs-devel@gnu.org
>> Date: Sat, 30 Jan 2021 19:44:56 +0000
>> native-lisp/28.0.50-x86_64-w64-mingw32-HASH1/titdic-cnv-HASH2-HASH3.eln
>> - HASH1 disambiguate triplet, Emacs configuration, version etc.
> But that information is already present in the text before:
> 28.0.50-x86_64-w64-mingw32.  What else is missing that we need a hash?

I left the text before as indicative and human readable but
unfortunatelly that's not complete.

The list of all primitive functions contribute to the eln linking
mechanism we use and is accounted in this hash.  Also we can trigger the
generation of a new hash each time we deploy an eln ABI breaking change.

>> The lenght of these hashes is coming directly from the algo we use
>> (md5), I think collision is really not an issue so we can easlily short
>> these.
> Then I think we should indeed short them, because this issue will bite
> us again.

That's easy, we should just pick a lenght we like.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]