[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 9291e73 02/12: Add new 'declare' forms for command completion
From: |
Basil L. Contovounesios |
Subject: |
Re: master 9291e73 02/12: Add new 'declare' forms for command completion predicates |
Date: |
Sun, 21 Feb 2021 14:11:05 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> This is the only declare form property that doesn't quote its value,
>> resulting in forms like (declare (completion 'foo)) rather than the more
>> conventional (declare (completion foo)). How's the following fix?
>
> But you can say
>
> (declare (completion (lambda (...) ...)))
Which my patch will turn into (function (lambda (...) ...)), which is
still correct and should be equivalent.
> So it's a list of functions, not a list of symbols...
What is a list? The completion-predicate property takes on a single
value satisfying functionp.
Both lambdas and symbols can be functions; my patch treats both equally,
so I see it as the correct treatment of this declare form property. If
you don't, then please elaborate on why not.
Thanks,
--
Basil